add fno-offload-uniform-block flag for rocm5.7 and up #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK, sure. |
junliume
approved these changes
Aug 9, 2023
junliume
approved these changes
Aug 9, 2023
junliume
reviewed
Aug 9, 2023
|
@junliume @illsilin I do not recommend adding the new option unconditionally, see ROCm/MIOpen#2307 (comment) |
|
I can run the full QA suite with rocm5.7 RC1 and this flag and see if there is any performance degradation. |
|
@illsilin That would be very good, thanks! Please update us with the results. |
|
Apparently, the rocm5.7 RC1 is the threshold version so the flag does not get set for it: |
|
@illsilin FYI this is how we use check_cxx_compiler_flag() in MIOpen (more future-proof solution): ROCm/MIOpen#2741 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should take care of the changes in the default compiler settings starting from rocm version 5.7.